carols10cents commented on code in PR #7839: URL: https://github.com/apache/arrow-rs/pull/7839#discussion_r2183609337
########## arrow-flight/Cargo.toml: ########## @@ -64,7 +64,7 @@ default = [] flight-sql = ["dep:arrow-arith", "dep:arrow-data", "dep:arrow-ord", "dep:arrow-row", "dep:arrow-select", "dep:arrow-string", "dep:once_cell", "dep:paste"] # TODO: Remove in the next release flight-sql-experimental = ["flight-sql"] -tls = ["tonic/tls"] +tls = ["tonic/tls-ring"] Review Comment: I _think_ if you add this, ~~then users won't be able to choose "tonic/tls-aws-lc" because they're mutually exclusive~~ nevermind, this is off by default. This would just be inconsistent and possibly confusing to only have a feature that turns on tonic/tls-ring but not tonic/tls-aws-lc, and someone using tonic/tls-aws-lc might go to turn on arrow-flight/tls and have a bad time. So either arrow-flight should add: ``` tls-ring = ["tonic/tls-ring"] tls-aws-lc = ["tonic/tls-aws-lc"] ``` or it should add nothing and assume feature unification from the user of arrow-flight also using tonic and configuring the feature with their use of tonic will take care of it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
