scovich opened a new pull request, #7865:
URL: https://github.com/apache/arrow-rs/pull/7865

   # Which issue does this PR close?
   
   - Closes https://github.com/apache/arrow-rs/issues/7863
   
   # Rationale for this change
   
   It turns out that creating a list or object builder has side effects that 
leave the parent in an inconsistent/invalid state if the child builder is never 
finalized. Rework the finalization logic to be more direct so that child 
builders have no effect on their parents before their `finish` method is called.
   
   # What changes are included in this PR?
   
   * Define a new `ParentState` enum that tracks the necessary information for 
a child to fully finalize its parent.
   * Remove the `pending` machinery from builders
   
   # Are these changes tested?
   
   Existing unit tests mostly cover this change. 
   
   Added new tests to verify that failing to call `finish` leaves the parent 
unmodified.
   
   # Are there any user-facing changes?
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to