scovich commented on code in PR #7865:
URL: https://github.com/apache/arrow-rs/pull/7865#discussion_r2186084248


##########
parquet-variant/src/builder.rs:
##########
@@ -1499,4 +1564,116 @@ mod tests {
         let valid_result = valid_obj.finish();
         assert!(valid_result.is_ok());
     }
+
+    #[test]
+    fn test_variant_builder_to_list_builder_no_finish() {
+        // Create a list builder but never finish it
+        let mut builder = VariantBuilder::new();
+        let _list_builder = builder.new_list();
+
+        builder.append_value(42i8);
+
+        // The original builder should be unchanged
+        let (metadata, value) = builder.finish();
+        let variant = Variant::try_new(&metadata, &value).unwrap();
+        assert_eq!(variant, Variant::Int8(42));
+    }
+
+    #[test]
+    fn test_variant_builder_to_object_builder_no_finish() {

Review Comment:
   I just tried cherry picking the tests to main branch and all four failed?
   ```
   % cargo test --no-fail-fast -- no_finish
     ...
   failures:
   
   ---- builder::tests::test_list_builder_to_list_builder_no_finish stdout ----
   thread 'builder::tests::test_list_builder_to_list_builder_no_finish' 
panicked at parquet-variant/src/builder.rs:1545:59:
   called `Result::unwrap()` on an `Err` value: InvalidArgumentError("Received 
empty bytes")
   note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
   
   ---- builder::tests::test_list_builder_to_object_builder_no_finish stdout 
----
   thread 'builder::tests::test_list_builder_to_object_builder_no_finish' 
panicked at parquet-variant/src/builder.rs:1566:59:
   called `Result::unwrap()` on an `Err` value: InvalidArgumentError("Received 
empty bytes")
   
   ---- builder::tests::test_object_builder_to_object_builder_no_finish stdout 
----
   thread 'builder::tests::test_object_builder_to_object_builder_no_finish' 
panicked at parquet-variant/src/builder.rs:1610:9:
   assertion `left == right` failed
     left: 3
    right: 2
   
   ---- builder::tests::test_object_builder_to_list_builder_no_finish stdout 
----
   thread 'builder::tests::test_object_builder_to_list_builder_no_finish' 
panicked at parquet-variant/src/builder.rs:1589:9:
   assertion `left == right` failed
     left: 3
    right: 2
   
   failures:
       builder::tests::test_list_builder_to_list_builder_no_finish
       builder::tests::test_list_builder_to_object_builder_no_finish
       builder::tests::test_object_builder_to_list_builder_no_finish
       builder::tests::test_object_builder_to_object_builder_no_finish
   
   test result: FAILED. 2 passed; 4 failed; 0 ignored; 0 measured; 90 filtered 
out; finished in 0.00s
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to