viirya commented on code in PR #7865:
URL: https://github.com/apache/arrow-rs/pull/7865#discussion_r2186021770
##########
parquet-variant/src/builder.rs:
##########
@@ -668,43 +739,41 @@ impl<'a, 'b> ObjectBuilder<'a, 'b> {
self
}
- /// Return a new [`ObjectBuilder`] to add a nested object with the
specified
- /// key to the object.
- pub fn new_object(&mut self, key: &'b str) -> ObjectBuilder {
- self.check_pending_field();
-
- let field_start = self.buffer.offset();
- let obj_builder = ObjectBuilder::new(&mut self.buffer,
self.metadata_builder)
- .with_validate_unique_fields(self.validate_unique_fields);
- self.pending = Some((key, field_start));
-
- obj_builder
+ // Returns validate_unique_fields because we can no longer reference self
once this method returns.
Review Comment:
Oh, it is mutable borrowed by the parent state.
##########
parquet-variant/src/builder.rs:
##########
@@ -668,43 +739,41 @@ impl<'a, 'b> ObjectBuilder<'a, 'b> {
self
}
- /// Return a new [`ObjectBuilder`] to add a nested object with the
specified
- /// key to the object.
- pub fn new_object(&mut self, key: &'b str) -> ObjectBuilder {
- self.check_pending_field();
-
- let field_start = self.buffer.offset();
- let obj_builder = ObjectBuilder::new(&mut self.buffer,
self.metadata_builder)
- .with_validate_unique_fields(self.validate_unique_fields);
- self.pending = Some((key, field_start));
-
- obj_builder
+ // Returns validate_unique_fields because we can no longer reference self
once this method returns.
Review Comment:
Oh, it is mutably borrowed by the parent state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
