EnricoMi commented on code in PR #46017:
URL: https://github.com/apache/arrow/pull/46017#discussion_r2194955749


##########
cpp/src/parquet/encryption/encryption.h:
##########
@@ -310,18 +325,22 @@ class PARQUET_EXPORT FileDecryptionProperties {
   }
 
  private:
-  std::string footer_key_;
+  ::arrow::util::SecureString footer_key_;
   std::string aad_prefix_;
   std::shared_ptr<AADPrefixVerifier> aad_prefix_verifier_;
 
+  // any empty SecureString key is interpreted as if no key is given
+  // this instance is used if a SecureString reference is returned
+  const ::arrow::util::SecureString no_key_ = ::arrow::util::SecureString();

Review Comment:
   Done in 184afcfd6d.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to