pitrou commented on code in PR #46017: URL: https://github.com/apache/arrow/pull/46017#discussion_r2207780809
########## cpp/src/parquet/encryption/encryption.h: ########## @@ -46,28 +48,56 @@ using ColumnPathToEncryptionPropertiesMap = class PARQUET_EXPORT DecryptionKeyRetriever { public: - virtual std::string GetKey(const std::string& key_metadata) = 0; + /// \brief Retrieve a key. + /// \deprecated Deprecated since 21.0.0. Review Comment: Ahem. 21.0.0 is nearly released, so we should actually rename all these deprecation notices to say 22.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org