pitrou commented on code in PR #46017:
URL: https://github.com/apache/arrow/pull/46017#discussion_r2195224148
##########
cpp/src/parquet/encryption/encryption.h:
##########
@@ -46,28 +48,39 @@ using ColumnPathToEncryptionPropertiesMap =
class PARQUET_EXPORT DecryptionKeyRetriever {
public:
- virtual std::string GetKey(const std::string& key_metadata) = 0;
+ /// \brief Retrieve a key.
+ virtual ::arrow::util::SecureString GetKey(const std::string& key_id) = 0;
+
virtual ~DecryptionKeyRetriever() {}
};
/// Simple integer key retriever
class PARQUET_EXPORT IntegerKeyIdRetriever : public DecryptionKeyRetriever {
public:
- void PutKey(uint32_t key_id, const std::string& key);
- std::string GetKey(const std::string& key_metadata) override;
+ void PutKey(uint32_t key_id, ::arrow::util::SecureString key);
+
+ ::arrow::util::SecureString GetKey(const std::string& key_id_string)
override {
+ // key_id_string is string but for IntegerKeyIdRetriever it encodes
Review Comment:
Fair enough. I do find the implementation weird as well, and I'm not sure
this class is actually useful, but hey :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
