alamb commented on code in PR #7818:
URL: https://github.com/apache/arrow-rs/pull/7818#discussion_r2201592759


##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -755,7 +755,7 @@ impl ArrowColumnWriter {
 }
 
 /// Encodes [`RecordBatch`] to a parquet row group
-struct ArrowRowGroupWriter {
+pub struct ArrowRowGroupWriter {

Review Comment:
   I do think avoiding exposing ArrowRowGroupWriter and the associated 
machinery that would be good
   
   The rationale is that @XiangpengHao  and @zhuqi-lucas and myself are likely 
to be reworking it in the next few releases and once it is part of the public 
API changing it becomes harder as it requires more coordination / backwards 
compatibility concerns



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to