scovich commented on code in PR #7888:
URL: https://github.com/apache/arrow-rs/pull/7888#discussion_r2198311436
##########
parquet-variant/src/variant.rs:
##########
@@ -256,6 +256,9 @@ pub enum Variant<'m, 'v> {
List(VariantList<'m, 'v>),
}
+// We don't want this to grow because it could hurt performance of a
frequently-created type.
+const _: () = crate::utils::expect_size_of::<Variant>(80);
Review Comment:
Assuming 8-byte alignment, and observing that we use explicit structs for
enum variant payloads which will prevent layout optimizations, I would expect
the (one-byte) discriminator for `Variant` to push the size from 64 bytes
(biggest enum variant payload) to 72 bytes (next alignment boundary). Where did
the other 8 bytes come from??
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
