scovich commented on code in PR #7888: URL: https://github.com/apache/arrow-rs/pull/7888#discussion_r2198781559
########## parquet-variant/src/variant.rs: ########## @@ -256,6 +256,9 @@ pub enum Variant<'m, 'v> { List(VariantList<'m, 'v>), } +// We don't want this to grow because it could hurt performance of a frequently-created type. +const _: () = crate::utils::expect_size_of::<Variant>(80); Review Comment: Ouch... figured it out -- i128 has 16-byte alignment, which poisons `VariantDecimal16` (whose `u8` scale pushes the size from 16 to 17 to 32 bytes) and `Variant` (whose one-byte discriminator pushes the size from 64 to 65 to 80 bytes). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org