jadewang-db commented on code in PR #3140:
URL: https://github.com/apache/arrow-adbc/pull/3140#discussion_r2205417095
##########
csharp/src/Drivers/Apache/Spark/SparkStatement.cs:
##########
@@ -32,28 +32,9 @@ internal SparkStatement(SparkConnection connection)
protected override void SetStatementProperties(TExecuteStatementReq
statement)
{
- // TODO: Ensure this is set dynamically depending on server
capabilities.
- statement.EnforceResultPersistenceMode = false;
- statement.ResultPersistenceMode =
TResultPersistenceMode.ALL_RESULTS;
// This seems like a good idea to have the server timeout so it
doesn't keep processing unnecessarily.
// Set in combination with a CancellationToken.
statement.QueryTimeout = QueryTimeoutSeconds;
- statement.CanReadArrowResult = true;
-
-#pragma warning disable CS0618 // Type or member is obsolete
- statement.ConfOverlay = SparkConnection.timestampConfig;
-#pragma warning restore CS0618 // Type or member is obsolete
- statement.UseArrowNativeTypes = new TSparkArrowTypes
- {
- TimestampAsArrow = true,
- DecimalAsArrow = true,
-
- // set to false so they return as string
Review Comment:
I think we should still keep this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
