toddmeng-db commented on code in PR #3140:
URL: https://github.com/apache/arrow-adbc/pull/3140#discussion_r2205896361


##########
csharp/src/Drivers/Databricks/DatabricksSchemaParser.cs:
##########
@@ -40,8 +64,8 @@ public override IArrowType GetArrowType(TPrimitiveTypeEntry 
thriftType, DataType
                 TTypeId.SMALLINT_TYPE => Int16Type.Default,

Review Comment:
   I have a feeling Timestamp type will also need to be String before Advanced 
Arrow type



##########
csharp/src/Drivers/Databricks/DatabricksSchemaParser.cs:
##########
@@ -40,8 +64,8 @@ public override IArrowType GetArrowType(TPrimitiveTypeEntry 
thriftType, DataType
                 TTypeId.SMALLINT_TYPE => Int16Type.Default,

Review Comment:
   I have a feeling Timestamp type will also need to be String before Advanced 
Arrow type, investigating



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to