toddmeng-db commented on code in PR #3140: URL: https://github.com/apache/arrow-adbc/pull/3140#discussion_r2205877188
########## csharp/src/Drivers/Databricks/DatabricksSchemaParser.cs: ########## @@ -16,15 +16,39 @@ */ using System; +using System.IO; using Apache.Arrow.Adbc.Drivers.Apache; using Apache.Arrow.Adbc.Drivers.Apache.Hive2; using Apache.Arrow.Types; using Apache.Hive.Service.Rpc.Thrift; +using Apache.Arrow.Ipc; namespace Apache.Arrow.Adbc.Drivers.Databricks { internal class DatabricksSchemaParser : SchemaParser Review Comment: A bit new to Arrow, not 100% sure if this is the correct way to handle consuming ArrowSchema (but this seems to work from manual testing). In particular, runtime populates ArrowSchema with ``` MessageSerializer.serialize(writeChannel, getArrowSchema()); ``` Which from what I understand can be correctly consumed using ``` using var stream = new MemoryStream(schemaBytes); using var reader = new ArrowStreamReader(stream);~ ``` Maybe @CurtHagenlocher @jadewang-db you may know better? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org