behrisch commented on PR #47114: URL: https://github.com/apache/arrow/pull/47114#issuecomment-3112878864
> From the above log, `warning C4275` is fired but it should be disabled already via `pragma warning(disable : 4275 4251)`. I guess the reason is that adding `pragma warning(pop)` to the `parquet/platform.h` header file will immediately swipe out all pushed pragmas at the end of this header file and any source file including `parquet/platform.h` will not see any pushed pragmas any more. Yes, that is also my understanding on how the push / pop mechanism works. The warnings are only disabled for everything between the push and the pop. So we either need to 1. fix the warning or 2. add another push/pop to exception.h or 3. add an include for exception.h to platform.h between the push and the pop so that exception.h won't be reread with the warnings being enabled. I would prefer option 2 but I have only very limited knowledge about the code base. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
