behrisch commented on PR #47114: URL: https://github.com/apache/arrow/pull/47114#issuecomment-3113976301
> Since `parquet/platform.h` is included by almost all files under parquet subdirectory, I don't think we need to add pop. But if you don't add the pop, the warning is disabled for every file which does `#include parquet/platform.h` directly or indirectly. So basically every code file using parquet (not only inside the library but also users of the library). That was the whole point of the issue #47099 as far as I am concerned. If you want to disable the warning only for the CI build, you could achieve this with a command line option to the compiler and get rid of the push as well. But every push needs its pop :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
