eitsupi commented on code in PR #3197:
URL: https://github.com/apache/arrow-adbc/pull/3197#discussion_r2244120953
##########
rust/driver_manager/src/lib.rs:
##########
@@ -720,6 +712,7 @@ fn set_option_database(
ERR_ONLY_STRING_OPT,
Status::NotImplemented,
))?,
+ (_, _) => unreachable!(),
Review Comment:
If there is no need to mark these enums as `non_exhaustive`, then this
condition is unnecessary.
https://github.com/apache/arrow-adbc/blob/314f0096b50538df8b4d4b34f95273481c22a7ad/rust/core/src/error.rs#L27-L28
https://github.com/apache/arrow-adbc/blob/314f0096b50538df8b4d4b34f95273481c22a7ad/rust/core/src/options.rs#L102-L103
In my opinion, it would be better if they were not `non_exhaustive`, since
if the enums were extended, it would not be noticed downstream.
@lidavidm Any thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
