eitsupi commented on code in PR #3197:
URL: https://github.com/apache/arrow-adbc/pull/3197#discussion_r2244215273
##########
rust/driver_manager/src/lib.rs:
##########
@@ -720,6 +712,7 @@ fn set_option_database(
ERR_ONLY_STRING_OPT,
Status::NotImplemented,
))?,
+ (_, _) => unreachable!(),
Review Comment:
After some thought, what do you think about the following approach?
1. Currently, the version of adbc_core is `0.y.z`, which is not a stable
version, so I think breaking changes due to enum extensions are relatively
tolerable.
Therefore, remove the `non_exhaustive` attribute from all enums except for
`AdbcVersion`.
2. Leave the `non_exhaustive` attribute only on AdbcVersion, which will
obviously be extended in the future.
3. Since it is desirable for adbc_driver_manager to cover all versions, we
use the nightly toolchain to have Clippy detect
`non_exhaustive_omitted_patterns` to prevent forgetting to update match arms.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
