lidavidm commented on code in PR #3197:
URL: https://github.com/apache/arrow-adbc/pull/3197#discussion_r2244224068
##########
rust/driver_manager/src/lib.rs:
##########
@@ -720,6 +712,7 @@ fn set_option_database(
ERR_ONLY_STRING_OPT,
Status::NotImplemented,
))?,
+ (_, _) => unreachable!(),
Review Comment:
Ah I see. You want to enforce that all arms are explicitly covered in the
driver manager crate, which non_exhaustive gets in the way of.
non_exhaustive_omitted_patterns sounds like a good way to handle that. I agree
with your proposal (remove non_exhaustive except on AdbcVersion and use
non_exhaustive_omitted_patterns option)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
