alamb commented on code in PR #8179:
URL: https://github.com/apache/arrow-rs/pull/8179#discussion_r2300543901
##########
parquet-variant-compute/src/variant_get/output/variant.rs:
##########
@@ -44,40 +85,92 @@ impl OutputBuilder for VariantOutputBuilder<'_> {
_value_field: &BinaryViewArray,
typed_value: &ArrayRef,
) -> arrow::error::Result<ArrayRef> {
- // in this case dispatch on the typed_value and
- // TODO macro'ize this using downcast! to handle all other primitive
types
// TODO(perf): avoid builders entirely (and write the raw variant
directly as we know the metadata is the same)
Review Comment:
Now that https://github.com/apache/arrow-rs/pull/8208 is done, we could use
the ReadOnlyMetadataBuilder (as a follow on PR)
##########
parquet-variant/src/variant.rs:
##########
@@ -1242,6 +1242,12 @@ impl From<VariantDecimal16> for Variant<'_, '_> {
}
}
+impl From<half::f16> for Variant<'_, '_> {
Review Comment:
- Filed https://github.com/apache/arrow-rs/issues/8228
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
