superserious-dev commented on PR #8179: URL: https://github.com/apache/arrow-rs/pull/8179#issuecomment-3229419418
Incorporated @scovich's suggestion and rebased on the latest main. One question: This PR introduces a few macros(eg. `numeric_perfectly_shredded_test`,` numeric_partially_shredded_test `, `numeric_perfectly_shredded_variant_array_fn`, `numeric_partially_shredded_variant_array_fn`) to reduce some boilerplate with the numeric tests; @klion26 Introduced an alternate approach for using functions that are generic over PrimitiveArray https://github.com/apache/arrow-rs/blob/1dacecba8e11cac307eea5d1a0f10c22d7f4a8b7/parquet-variant-compute/src/variant_get/mod.rs#L368-L387. I can see pros and cons to each: - the macro approach reduces some boilerplate while making it harder to read the tests - the generic approach makes the tests easier to understand at the cost of some more boilerplate Any suggestions for whether to keep the macros in this PR or switch over to the generic functions? There are also quite a few conversion left, so trying to consider what would work well for those. - StringTypes: DataType::Utf8, Utf8View, etc - BinaryTypes: Binary, BinaryView, etc - Boolean - Time Types - Date Types - Timestamp Types -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
