superserious-dev commented on code in PR #8179:
URL: https://github.com/apache/arrow-rs/pull/8179#discussion_r2304957672
##########
parquet-variant-compute/src/variant_get/output/variant.rs:
##########
@@ -18,11 +18,52 @@
use crate::variant_get::output::OutputBuilder;
use crate::{VariantArray, VariantArrayBuilder};
use arrow::array::{Array, ArrayRef, AsArray, BinaryViewArray};
-use arrow::datatypes::Int32Type;
+use arrow::datatypes::{
+ Float16Type, Float32Type, Float64Type, Int16Type, Int32Type, Int64Type,
Int8Type, UInt16Type,
+ UInt32Type, UInt64Type, UInt8Type,
+};
use arrow_schema::{ArrowError, DataType};
use parquet_variant::{Variant, VariantPath};
use std::sync::Arc;
+macro_rules! cast_perfectly_shredded_primitive {
+ ($typed_value:expr, $variant_array:expr, $arrow_type:ty, $data_type:expr)
=> {{
+ let mut array_builder = VariantArrayBuilder::new($variant_array.len());
+ let primitive_array = $typed_value.as_primitive::<$arrow_type>();
+ for i in 0..$variant_array.len() {
+ if primitive_array.is_null(i) {
+ array_builder.append_null();
+ } else {
+ let value = primitive_array.value(i);
+ array_builder.append_variant(Variant::from(value));
+ }
+ }
Review Comment:
I switched over to using the merged macro.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
