zeroshade commented on code in PR #485:
URL: https://github.com/apache/arrow-go/pull/485#discussion_r2304430737
##########
parquet/file/page_reader.go:
##########
@@ -574,7 +588,7 @@ func (p *serializedPageReader) GetDictionaryPage()
(*DictionaryPage, error) {
return &DictionaryPage{
page: page{
- buf: memory.NewBufferBytes(data),
+ buf: buf,
Review Comment:
this can become a problem due to race conditions. If a new DictionaryPage is
read in by the reader while this page is still in use, you'll end up
overwriting data that is still being used. That's why we were creating a new
buffer here, to avoid the potential race condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
