zeroshade commented on code in PR #485:
URL: https://github.com/apache/arrow-go/pull/485#discussion_r2304432969
##########
parquet/file/page_reader.go:
##########
@@ -728,7 +740,7 @@ func (p *serializedPageReader) Next() bool {
// make dictionary page
p.curPage = &DictionaryPage{
page: page{
- buf: memory.NewBufferBytes(data),
+ buf: buf,
Review Comment:
same comment as above. we should utilize a buffer pool instead most likely
##########
parquet/file/page_reader.go:
##########
@@ -759,7 +774,7 @@ func (p *serializedPageReader) Next() bool {
// make datapagev1
p.curPage = &DataPageV1{
page: page{
- buf: memory.NewBufferBytes(data),
+ buf: buf,
Review Comment:
same issue as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
