davidhcoe commented on code in PR #3157:
URL: https://github.com/apache/arrow-adbc/pull/3157#discussion_r2309061440
##########
csharp/src/Drivers/BigQuery/BigQueryConnection.cs:
##########
@@ -136,30 +136,30 @@ internal BigQueryClient Open(string? projectId = null)
if (projectId.Equals(BigQueryConstants.PublicProjectId,
StringComparison.OrdinalIgnoreCase))
{
projectId = BigQueryConstants.DetectProjectId;
-
activity?.AddBigQueryTag("change_public_projectId_to_detect_project_id",
projectId);
+
activity?.AddBigQueryTag("change_public_projectId_to_detect_project_id",
projectId, isPii: false);
}
}
// the billing project can be null if it's not specified
if
(this.properties.TryGetValue(BigQueryParameters.BillingProjectId, out
billingProjectId))
{
-
activity?.AddBigQueryParameterTag((BigQueryParameters.BillingProjectId),
billingProjectId);
+
activity?.AddBigQueryParameterTag((BigQueryParameters.BillingProjectId),
billingProjectId, isPii: false);
Review Comment:
I could see this potentially being pii, based on how people name their
projects.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
