davidhcoe commented on code in PR #3157:
URL: https://github.com/apache/arrow-adbc/pull/3157#discussion_r2309081879
##########
csharp/src/Drivers/Databricks/Reader/DatabricksReader.cs:
##########
@@ -62,7 +62,7 @@ public DatabricksReader(IHiveServer2Statement statement,
Schema schema, IRespons
RecordBatch? next = await
this.reader.ReadNextRecordBatchAsync(cancellationToken);
if (next != null)
{
-
activity?.AddEvent(SemanticConventions.Messaging.Batch.Response,
[new(SemanticConventions.Db.Response.ReturnedRows, next.Length)]);
+
activity?.AddEvent(SemanticConventions.Messaging.Batch.Response,
[new(SemanticConventions.Db.Response.ReturnedRows, next.Length)], isPii: false);
Review Comment:
We've traditionally thought of exceptions has containing PII because of the
nature of the messages. It could be as mundane as a ArgumentInvalidException to
an elaborate `new NewFangledException("david did this")` and the message could
be anything. Is there a scenario where this would be set to false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
