birschick-bq commented on code in PR #3157:
URL: https://github.com/apache/arrow-adbc/pull/3157#discussion_r2309121295
##########
csharp/src/Drivers/Databricks/Reader/DatabricksReader.cs:
##########
@@ -62,7 +62,7 @@ public DatabricksReader(IHiveServer2Statement statement,
Schema schema, IRespons
RecordBatch? next = await
this.reader.ReadNextRecordBatchAsync(cancellationToken);
if (next != null)
{
-
activity?.AddEvent(SemanticConventions.Messaging.Batch.Response,
[new(SemanticConventions.Db.Response.ReturnedRows, next.Length)]);
+
activity?.AddEvent(SemanticConventions.Messaging.Batch.Response,
[new(SemanticConventions.Db.Response.ReturnedRows, next.Length)], isPii: false);
Review Comment:
I've removed all the `exceptionIsPii: false` for all occurrences. Do you
think I should remove the optional parameter, altogether?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
