felipecrv commented on code in PR #3381:
URL: https://github.com/apache/arrow-adbc/pull/3381#discussion_r2314189083
##########
rust/core/src/error.rs:
##########
@@ -22,6 +22,10 @@ use std::{ffi::NulError, fmt::Display};
use arrow_schema::ArrowError;
+use crate::constants;
+
+pub type AdbcStatusCode = u8;
Review Comment:
Just return u8 on the FFI side. We only need u8 to AdbcStatus Into<T>. Let's
not have 2 layers of conversions for an enum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
