felipecrv commented on code in PR #3381:
URL: https://github.com/apache/arrow-adbc/pull/3381#discussion_r2314593486
##########
rust/core/src/options.rs:
##########
@@ -37,7 +37,7 @@ pub enum OptionValue {
impl OptionValue {
/// Gets the data type of the option's value.
- pub(crate) fn get_type(&self) -> &str {
+ pub fn get_type(&self) -> &str {
Review Comment:
@mbrobbel why move this and what is the problem of exposing this simple
method as a pub? It doesn't break any encapsulation. It's a convenient getter
that enables printing more detailed debug information.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
