jecsand838 commented on code in PR #8348:
URL: https://github.com/apache/arrow-rs/pull/8348#discussion_r2348025668
##########
arrow-avro/src/codec.rs:
##########
@@ -804,36 +870,79 @@ fn parse_decimal_attributes(
Ok((precision, scale, size))
}
-impl Codec {
- /// Converts a string codec to use Utf8View if requested
- ///
- /// The conversion only happens if both:
- /// 1. `use_utf8view` is true
- /// 2. The codec is currently `Utf8`
- ///
- /// # Example
- /// ```
- /// # use arrow_avro::codec::Codec;
- /// let utf8_codec1 = Codec::Utf8;
- /// let utf8_codec2 = Codec::Utf8;
- ///
- /// // Convert to Utf8View
- /// let view_codec = utf8_codec1.with_utf8view(true);
- /// assert!(matches!(view_codec, Codec::Utf8View));
- ///
- /// // Don't convert if use_utf8view is false
- /// let unchanged_codec = utf8_codec2.with_utf8view(false);
- /// assert!(matches!(unchanged_codec, Codec::Utf8));
- /// ```
- pub fn with_utf8view(self, use_utf8view: bool) -> Self {
- if use_utf8view && matches!(self, Self::Utf8) {
- Self::Utf8View
- } else {
- self
Review Comment:
I just moved this code to the other `Codec` implementation block to
consolidate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
