jecsand838 commented on code in PR #8348:
URL: https://github.com/apache/arrow-rs/pull/8348#discussion_r2348018266
##########
arrow-avro/src/codec.rs:
##########
@@ -1281,10 +1587,9 @@ impl<'a> Maker<'a> {
nullable_union_variants(writer_variants),
nullable_union_variants(reader_variants),
) {
- (Some((_, write_nonnull)), Some((read_nb, read_nonnull))) => {
+ (Some((write_nb, write_nonnull)), Some((_read_nb, read_nonnull)))
=> {
Review Comment:
I realized while regression testing Unions that it made more sense and
resulted in less complexity in Union decoding to use the writer's null
ordering. This in itself also does not deviate from the Avro specification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
