jecsand838 commented on PR #8348: URL: https://github.com/apache/arrow-rs/pull/8348#issuecomment-3305027108
> Thanks @jecsand838 -- as always I found the PR easy to read and understand, though given my limited avro knowledge I will not be able to pick up subtle avro issues. > > The only thing I didn't see in this PR was "end to end" tests -- namely reading union data into arrow UnionArrays > > Ideally we would also have round trip tests where we wrote a `UnionArray` to avro and the read it back again ensuring the resulting array was the same @alamb Absolutely! So I have the end to end tests in the part 2 PR #8349 . This PR only covers the codec and schema changes. The part 2 PR has the decoder updates and end to end tests along with a new test file containing all possible Union type scenarios. I just couldn't find a cleaner way to break the work up. Also the roundtrip tests will be in @nathaniel-d-ef 's upcoming PR for `Union` type support in the `Writer`. Let me know if you're okay with this breakdown. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
