alinaliBQ commented on code in PR #40939: URL: https://github.com/apache/arrow/pull/40939#discussion_r2380245113
########## cpp/src/arrow/flight/sql/odbc/flight_sql/accessors/types.h: ########## @@ -0,0 +1,148 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#pragma once + +#include <cstddef> +#include <cstdint> +#include <sstream> + +#include "arrow/array.h" +#include "arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/diagnostics.h" +#include "arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/exceptions.h" +#include "arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/platform.h" +#include "arrow/flight/sql/odbc/odbcabstraction/include/odbcabstraction/types.h" + +namespace driver { +namespace flight_sql { + +using arrow::Array; +using odbcabstraction::CDataType; + +class FlightSqlResultSet; + +struct ColumnBinding { + void* buffer; + ssize_t* strlen_buffer; + size_t buffer_length; + CDataType target_type; + int precision; + int scale; + + ColumnBinding() = default; + + ColumnBinding(CDataType target_type, int precision, int scale, void* buffer, + size_t buffer_length, ssize_t* strlen_buffer) + : target_type(target_type), + precision(precision), + scale(scale), + buffer(buffer), + buffer_length(buffer_length), + strlen_buffer(strlen_buffer) {} +}; + +/// \brief Accessor interface meant to provide a way of populating data of a +/// single column to buffers bound by `ColumnarResultSet::BindColumn`. +class Accessor { + public: + const CDataType target_type_; + + explicit Accessor(CDataType target_type) : target_type_(target_type) {} + + virtual ~Accessor() = default; + + /// \brief Populates next cells + virtual size_t GetColumnarData(ColumnBinding* binding, int64_t starting_row, + size_t cells, int64_t& value_offset, + bool update_value_offset, + odbcabstraction::Diagnostics& diagnostics, + uint16_t* row_status_array) = 0; + + virtual size_t GetCellLength(ColumnBinding* binding) const = 0; +}; + +template <typename ARROW_ARRAY, CDataType TARGET_TYPE, typename DERIVED> +class FlightSqlAccessor : public Accessor { + public: + explicit FlightSqlAccessor(Array* array) + : Accessor(TARGET_TYPE), + array_(arrow::internal::checked_cast<ARROW_ARRAY*>(array)) {} + + size_t GetColumnarData(ColumnBinding* binding, int64_t starting_row, size_t cells, + int64_t& value_offset, bool update_value_offset, + odbcabstraction::Diagnostics& diagnostics, + uint16_t* row_status_array) override { + return static_cast<DERIVED*>(this)->GetColumnarData_impl( + binding, starting_row, cells, value_offset, update_value_offset, diagnostics, + row_status_array); + } + + size_t GetCellLength(ColumnBinding* binding) const override { + return static_cast<const DERIVED*>(this)->GetCellLength_impl(binding); + } + + protected: + size_t GetColumnarData_impl(ColumnBinding* binding, int64_t starting_row, int64_t cells, + int64_t& value_offset, bool update_value_offset, + odbcabstraction::Diagnostics& diagnostics, + uint16_t* row_status_array) { + for (int64_t i = 0; i < cells; ++i) { + int64_t current_arrow_row = starting_row + i; + if (array_->IsNull(current_arrow_row)) { + if (binding->strlen_buffer) { + binding->strlen_buffer[i] = odbcabstraction::NULL_DATA; + } else { + throw odbcabstraction::NullWithoutIndicatorException(); + } + } else { + // TODO: Optimize this by creating different versions of MoveSingleCell + // depending on if strlen_buffer is null. + auto row_status = MoveSingleCell(binding, current_arrow_row, i, value_offset, + update_value_offset, diagnostics); + if (row_status_array) { + row_status_array[i] = row_status; + } + } + } + + return static_cast<size_t>(cells); + } + + inline ARROW_ARRAY* GetArray() { return array_; } + + private: + ARROW_ARRAY* array_; + + odbcabstraction::RowStatus MoveSingleCell(ColumnBinding* binding, int64_t arrow_row, + int64_t i, int64_t& value_offset, + bool update_value_offset, + odbcabstraction::Diagnostics& diagnostics) { + return static_cast<DERIVED*>(this)->MoveSingleCell_impl( + binding, arrow_row, i, value_offset, update_value_offset, diagnostics); + } + + odbcabstraction::RowStatus MoveSingleCell_impl( + ColumnBinding* binding, int64_t arrow_row, int64_t i, int64_t& value_offset, + bool update_value_offset, odbcabstraction::Diagnostics& diagnostics) { + std::stringstream ss; + ss << "Unknown type conversion from StringArray to target C type " << TARGET_TYPE; + throw odbcabstraction::DriverException(ss.str()); Review Comment: I think it is okay to keep these as exceptions. The driver will catch the exception and error out to the user. The ODBC driver has a dependency to arrow-flight-sql, but I think it doesn't prevent the driver from being moved to its own toplevel source. Our team is open to hear what the community thinks on this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
