Vishwanatha-HD commented on code in PR #48166:
URL: https://github.com/apache/arrow/pull/48166#discussion_r2544978982
##########
cpp/src/arrow/ipc/message_internal_test.cc:
##########
@@ -74,6 +76,29 @@ TEST(TestMessageInternal, TestByteIdentical) {
0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x66, 0x30, 0x00, 0x00,
0x08, 0x00,
0x0C, 0x00, 0x08, 0x00, 0x07, 0x00, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x01,
0x40, 0x00, 0x00, 0x00};
+#else
+ // On Big-endian systems, 4 bytes are appended to indicate it as a BE
system. Hence the
+ // total size is 4 bytes more than the LE systems.
Review Comment:
@kou..
I guess, I need to modify the comment here.. The root cause for this
testcase failure is as below:
The test was failing because it contained a hardcoded expected byte array
that was generated on macOS+ARM+LLVM, but in our case, the test was running on
a Linux+s390x+GCC platform. FlatBuffer serialization can produce slightly
different output across different platforms and toolchains, which caused the
buffer size mismatch (expected 232 bytes vs actual 228 bytes).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
