pitrou commented on code in PR #48166:
URL: https://github.com/apache/arrow/pull/48166#discussion_r2556535666
##########
cpp/src/arrow/ipc/message_internal_test.cc:
##########
@@ -74,6 +76,29 @@ TEST(TestMessageInternal, TestByteIdentical) {
0x00, 0x00, 0x00, 0x00, 0x02, 0x00, 0x00, 0x00, 0x66, 0x30, 0x00, 0x00,
0x08, 0x00,
0x0C, 0x00, 0x08, 0x00, 0x07, 0x00, 0x08, 0x00, 0x00, 0x00, 0x00, 0x00,
0x00, 0x01,
0x40, 0x00, 0x00, 0x00};
+#else
+ // On Big-endian systems, FlatBuffer serialization can produce slightly
different
+ // output across different platforms and toolchains.
Review Comment:
Er, ok, but there is a well-defined explanation to this: a Arrow schema has
an endianness attached to it, and it defaults to the platform's endianness.
To obey the intent of this test case, you should instead change the schema
instantiation above to:
```c++
auto schema = ::arrow::schema({f0}, Endianness::Little, metadata);
```
Does this change solve the issue on s390x?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
