pitrou commented on code in PR #48166:
URL: https://github.com/apache/arrow/pull/48166#discussion_r2557543557
##########
cpp/src/arrow/acero/hash_join.cc:
##########
@@ -306,19 +307,40 @@ class HashJoinBasicImpl : public HashJoinImpl {
size_t num_probed_rows = match.size() + no_match.size();
if (mask.is_scalar()) {
+#if ARROW_LITTLE_ENDIAN
const auto& mask_scalar = mask.scalar_as<BooleanScalar>();
if (mask_scalar.is_valid && mask_scalar.value) {
// All rows passed, nothing left to do
return Status::OK();
- } else {
- // Nothing passed, no_match becomes everything
- no_match.resize(num_probed_rows);
- std::iota(no_match.begin(), no_match.end(), 0);
- match_left.clear();
- match_right.clear();
- match.clear();
- return Status::OK();
}
+#else
+ // Check if the scalar is a BooleanScalar before casting
Review Comment:
@zanmato1984 Can you take a look at this? I honestly don't understand why we
wouldn't get a boolean scalar on a big-endian system...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
