mkleen commented on code in PR #8988:
URL: https://github.com/apache/arrow-rs/pull/8988#discussion_r2621093631
##########
arrow/benches/zip_kernels.rs:
##########
@@ -224,6 +223,74 @@ fn bench_zip_input_on_all_masks(
}
}
+fn bench_zip_on_string_view_scalar(c: &mut Criterion, input_generator:
&GenerateStringView) {
+ bench_zip_on_string_view_scalars(c, input_generator, input_generator);
+}
+
+fn bench_zip_on_string_view_scalars(
+ c: &mut Criterion,
+ input_generator_1: &GenerateStringView,
+ input_generator_2: &GenerateStringView,
+) {
+ let mut group = c.benchmark_group(
+ format!(
+ "zip_{ARRAY_LEN}_from_{} and {}",
+ input_generator_1.name(),
+ input_generator_2.name()
+ )
+ .as_str(),
+ );
+
+ let null_scalar = input_generator_1.generate_null();
+
+ let non_null_scalar_1 = input_generator_1.generate();
Review Comment:
Ok, the generator returns now scalars instead of arrays directly. Regarding
the combinations: I still think they are valid. The optimisation is based on
scalar vs scalar values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
