prmoore77 commented on code in PR #3810:
URL: https://github.com/apache/arrow-adbc/pull/3810#discussion_r2623996914
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -372,6 +378,11 @@ def close(self) -> None:
if self._closed:
return
+ # Close all open cursors first to avoid RuntimeError from
+ # AdbcConnection about open children
+ for cursor in list(self._cursors):
+ cursor.close()
Review Comment:
I'm not sure what to do here - b/c if we fail to close one (or more) of the
connection's cursors for some reason - won't we hit the original error when we
attempt to close the connection (from the Go driver)?
`RuntimeError: Cannot close AdbcConnection with open AdbcStatement`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
