lidavidm commented on code in PR #3810:
URL: https://github.com/apache/arrow-adbc/pull/3810#discussion_r2624131091
##########
python/adbc_driver_manager/adbc_driver_manager/dbapi.py:
##########
@@ -372,6 +378,14 @@ def close(self) -> None:
if self._closed:
return
+ # Try to close all open cursors first to avoid RuntimeError from
+ # AdbcConnection about open children
+ for cursor in self._cursors:
+ try:
+ cursor.close()
+ except Exception:
+ pass
Review Comment:
If we're going to do this, IMO it should at least get emitted as a
ResourceWarning or something.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
