alamb commented on code in PR #9199:
URL: https://github.com/apache/arrow-rs/pull/9199#discussion_r2699653544
##########
CHANGELOG.md:
##########
@@ -19,6 +19,12 @@
# Changelog
+## [Unreleased]
+
+**Breaking changes:**
Review Comment:
Technically this is not a breaking change -- as you left the backwards
compatibility APIs
##########
parquet/tests/arrow_reader/io/async_reader.rs:
##########
@@ -318,7 +319,9 @@ async fn async_builder(
test_file: &TestParquetFile,
options: ArrowReaderOptions,
) -> ParquetRecordBatchStreamBuilder<RecordingAsyncFileReader> {
- let parquet_meta_data = if options.page_index() {
+ let parquet_meta_data = if options.offset_index_policy() !=
PageIndexPolicy::Skip
+ || options.column_index_policy() != PageIndexPolicy::Skip
Review Comment:
should this be "&&" in stead of "||"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
