friendlymatthew commented on code in PR #9199:
URL: https://github.com/apache/arrow-rs/pull/9199#discussion_r2700104593
##########
parquet/tests/arrow_reader/io/async_reader.rs:
##########
@@ -318,7 +319,9 @@ async fn async_builder(
test_file: &TestParquetFile,
options: ArrowReaderOptions,
) -> ParquetRecordBatchStreamBuilder<RecordingAsyncFileReader> {
- let parquet_meta_data = if options.page_index() {
+ let parquet_meta_data = if options.offset_index_policy() !=
PageIndexPolicy::Skip
+ || options.column_index_policy() != PageIndexPolicy::Skip
Review Comment:
My reasoning here was the original `page_index()` returned
`page_index_policy != PageIndexPolicy::Skip`. Since `page_index_policy` was
split into separate `offset_index_policy` and `column_index_policy`, we should
keep the page index if *either* policy is not Skip.
In other words, we only strip the page index when *both* are skip.
But I am happy to make the change if this is the incorrect reasoning
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
