etseidl commented on code in PR #9199:
URL: https://github.com/apache/arrow-rs/pull/9199#discussion_r2699885817
##########
parquet/src/arrow/async_reader/store.rs:
##########
@@ -226,8 +226,12 @@ impl AsyncFileReader for ParquetObjectReader {
// When page_index_policy is Optional or Required, override the
preload flags
// to ensure the specified policy takes precedence.
if let Some(options) = options {
- if options.page_index_policy != PageIndexPolicy::Skip {
- metadata =
metadata.with_page_index_policy(options.page_index_policy);
+ if options.column_index_policy() != PageIndexPolicy::Skip
Review Comment:
I think `||` is fine, or just split them up and test/set individually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
