alamb commented on a change in pull request #55:
URL: https://github.com/apache/arrow-datafusion/pull/55#discussion_r622169779
##########
File path: datafusion/src/logical_plan/plan.rs
##########
@@ -141,7 +137,7 @@ pub enum LogicalPlan {
/// Produces rows from a table provider by reference or from the context
TableScan {
/// The name of the table
- table_name: String,
+ table_name: Option<String>,
Review comment:
I guess I don't fully understand how we could be scanning relations that
don't have names (like how do you refer to them in SQL?) As I recall, postgres
doesn't use the term 'table name' and instead uses the word 'relation name' as
the name can come from a table, or an alias, or subquery (and probably others I
am not remembering now)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
