westonpace commented on pull request #10255: URL: https://github.com/apache/arrow/pull/10255#issuecomment-833171709
Ah, I hadn't realized we had `newlines_in_values`. Yes, sounds like there is a bit of complexity but you have a good grip on it. > I assume that skip_rows would have to be kept but deprecated. I don't think so but I'll let @pitrou weigh in. As long as there is a good reason for it the project seems to be in a place where breaking changes are ok. Especially since this one would be pretty trivial to understand and adapt to. > There might be a way to also tackle https://issues.apache.org/jira/browse/ARROW-8527 with this change. That would be good. Eventually the dataset scanner will probably be getting a skip operation of some kind as well so that'll increase the pressure on ARROW-8527. ARROW-12598 is also (admittedly tangentially) related since you seem to be on a roll :smile: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
