n3world commented on a change in pull request #10255:
URL: https://github.com/apache/arrow/pull/10255#discussion_r629383462



##########
File path: cpp/src/arrow/csv/reader_test.cc
##########
@@ -216,5 +216,83 @@ TEST(StreamingReaderTests, NestedParallelism) {
   TestNestedParallelism(thread_pool, table_factory);
 }
 
+TEST(ReaderOptionsTests, SkipRowsAfterNames) {

Review comment:
       I can look into writing them in python. I just wrote the test in C++ 
because I implemented the feature in C++.
   Right now I am actually not working on this because after the above 
discussions I was under the impression that the desired implementation would be 
to have skip_rows be a list of ranges of row indexes to skip. With that in mind 
I actually started to work on https://issues.apache.org/jira/browse/ARROW-12675 
so that the parser could know what absolute line number it was parsing and 
could skip the line.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to