pitrou commented on a change in pull request #10255:
URL: https://github.com/apache/arrow/pull/10255#discussion_r629351629



##########
File path: cpp/src/arrow/csv/reader_test.cc
##########
@@ -216,5 +216,83 @@ TEST(StreamingReaderTests, NestedParallelism) {
   TestNestedParallelism(thread_pool, table_factory);
 }
 
+TEST(ReaderOptionsTests, SkipRowsAfterNames) {

Review comment:
       These options are currently tested on the Python side, so I would 
appreciate if you wrote your tests in Python instead (also, they'll be easier 
to write :-)). This implies that you need to expose the new option in Python as 
well. If that is difficult for you, please say so and we can help.
   
   See 
https://github.com/apache/arrow/blob/master/python/pyarrow/tests/test_csv.py#L286




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to