alamb commented on code in PR #9820:
URL: https://github.com/apache/arrow-rs/pull/9820#discussion_r3148972522
##########
arrow-buffer/src/buffer/mutable.rs:
##########
@@ -583,7 +586,11 @@ impl MutableBuffer {
/// Extends the buffer by `additional` bytes equal to `0u8`, incrementing
its capacity if needed.
#[inline]
pub fn extend_zeros(&mut self, additional: usize) {
- self.resize(self.len + additional, 0);
+ let new_len = self
+ .len
+ .checked_add(additional)
+ .expect("buffer length overflow");
Review Comment:
I agree panics are not good and should be avoided when possible
We had a bit of a philosophical debate about this earlier (when to panic vs
Error) and the conclusion we came to got codified in this doc, which I think is
relevant here: https://github.com/apache/arrow-rs#guidelines-for-panic-vs-result
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
