scovich commented on code in PR #9820:
URL: https://github.com/apache/arrow-rs/pull/9820#discussion_r3149106762
##########
arrow-buffer/src/buffer/mutable.rs:
##########
@@ -583,7 +586,11 @@ impl MutableBuffer {
/// Extends the buffer by `additional` bytes equal to `0u8`, incrementing
its capacity if needed.
#[inline]
pub fn extend_zeros(&mut self, additional: usize) {
- self.resize(self.len + additional, 0);
+ let new_len = self
+ .len
+ .checked_add(additional)
+ .expect("buffer length overflow");
Review Comment:
These are 64-bit values right? Probably ok to leave it as a panic because
last I knew most hardware cannot physically index more than 48 bits of virtual
memory and most operating systems cap the size of any one memory mapping to a
few TB of contiguous virtual address space (even one not backed by memory).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
