alamb commented on code in PR #9850:
URL: https://github.com/apache/arrow-rs/pull/9850#discussion_r3163025709
##########
arrow-array/src/array/fixed_size_binary_array.rs:
##########
@@ -486,6 +485,8 @@ impl FixedSizeBinaryArray {
})
}
+ /// Returns the byte offset for the element at index `i` without
+ /// checking for overflow.
#[inline]
fn value_offset_at(&self, i: usize) -> i32 {
self.value_length * i as i32
Review Comment:
this arithmetic can overflow if the result is larger than `i32::MAX`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
