alamb commented on code in PR #9850:
URL: https://github.com/apache/arrow-rs/pull/9850#discussion_r3170266352
##########
arrow-array/src/array/fixed_size_binary_array.rs:
##########
@@ -186,7 +185,7 @@ impl FixedSizeBinaryArray {
/// # Safety
///
/// Caller is responsible for ensuring that the index is within the bounds
- /// of the array
+ /// of the array and the resulting byte offset fits in `i32`
pub unsafe fn value_unchecked(&self, i: usize) -> &[u8] {
Review Comment:
Short answer is yes. I also spent some more time reviewing the code in
FixedSizeBinaryArray and I am now convinced there are several other miuses of
`i32` <-> `usize` . I am working on an improvement, though I worry it will be a
larger PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
