alamb commented on PR #9850: URL: https://github.com/apache/arrow-rs/pull/9850#issuecomment-4361589777
> I have played around with several options for improving this code. I think there are several potential i32 math overflow issues, but fixing them all in a single PR is going to be somewhat hard to review and take some time > > What I am thinking about is adding a new invariant to the FixedSizeArray constructor that prevents constructing arrays with value buffers larger than 2GB as a temporary workaround in one PR. Then I can fixup the actual arithmetic in a second: I took this approach in the following PR: - https://github.com/apache/arrow-rs/pull/9872 I will create a follow on PR from that one that changes the internals of FixedSizeBinary to use `usize` arithmetic everywhere, but that will be a more invasive change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
